feat(init): let accountless setup run on every framework - #470
Draft
djgould wants to merge 1 commit into
Draft
Conversation
Remove the supportsKeyless gate and the agent-mode "manual" strategy. The CLI mints the accountless app itself and only needs the framework's env var names, so Vue, React, JavaScript, Expo, Express, Fastify, iOS, and Android resolve to accountless like Next.js. iOS and Android get only the publishable key in .env, mirroring env pull. Co-Authored-By: Claude Fable 5.1 <[email protected]>
🦋 Changeset detectedLatest commit: e4fff30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
supportsKeylessframework gate fromclerk init. The CLI mints the accountless app itself (#395) and only needs the framework's env var names, so the gate — added when minting was going to be delegated to the SDKs (#131, plan dropped in #267) — no longer gates anything real.--accountlessworks everywhere, and the agent-mode "set up keys manually" fallback is gone..env(their templates don't gitignore it), mirroringenv pull.clerk env pull" wording that was wrong for accountless runs.Verified against production from source, logged out: Vue (bootstrap), Express, iOS, and React each minted an app and wrote the right env file; iOS got only the publishable key. E2E didn't run locally (1Password vault not accessible from this account), so CI is the check for that suite.
Left for follow-ups: sending the Dashboard's framework id as
Clerk-Framework(and carrying it on theclerk openclaim link), and a breadcrumb key fallback so CLI commands can reach an unclaimed iOS/Android app before claim.🤖 Generated with Claude Code